[Rpm-maint] [rpm-software-management/rpm] Unify glob fallback behavior (PR #2159)

Michal Domonkos notifications at github.com
Mon Aug 22 16:02:02 UTC 2022


In the `%files` section, we currently try to match globs literally if they don't expand to any existing files. This doesn't include special (`%doc` and `%license`) files so fix that. To make this behavior consistent everywhere, also do the same kind of fallback on the CLI when reading package names.

As a side effect, error reporting for globs is now unified with that for non-glob files as we pass both through the same IO routines.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2159

-- Commit Summary --

  * Add test for missing %files entries
  * Fall back to literal glob in %doc and %license
  * Move common fallback code from %files to rpmGlob()
  * Bump glob fallback message in %files to warning
  * Refactor processBinaryFile()
  * Add tests for package globs on CLI
  * Fall back to literal package glob on CLI

-- File Changes --

    M build/files.c (50)
    M build/rpmfc.c (2)
    M docs/manual/spec.md (4)
    M include/rpm/rpmfileutil.h (13)
    M lib/manifest.c (2)
    M lib/rpmdb.c (2)
    M lib/rpmgi.c (2)
    M lib/rpminstall.c (2)
    M lib/rpmrc.c (2)
    M lib/rpmts.c (2)
    M lib/transaction.c (2)
    M rpmio/macro.c (2)
    M rpmio/rpmglob.c (22)
    A tests/data/SPECS/filemiss.spec (26)
    M tests/data/SPECS/globesctest.spec (10)
    M tests/rpmbuild.at (36)
    M tests/rpmi.at (135)
    M tests/rpmquery.at (66)
    M tools/rpmgraph.c (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2159.patch
https://github.com/rpm-software-management/rpm/pull/2159.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2159
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2159 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220822/f7abaa91/attachment-0001.html>


More information about the Rpm-maint mailing list