[Rpm-maint] [rpm-software-management/rpm] Unify glob fallback behavior (PR #2159)

[Panu Matilainen]

@pmatilai commented on this pull request.



>   * @param[out] *argcPtr	no. of paths
  * @param[out] *argvPtr	ARGV_t array of paths
  * @return		0 on success
  */
-int rpmGlob(const char * pattern, int * argcPtr, ARGV_t * argvPtr);
+int rpmGlob(const char * pattern, rpmglobFlags flags,
+	    int * argcPtr, ARGV_t * argvPtr);

Not a complete review but this caught my eye:

Technically, this is part of our public API and we can't just silently change it. 

The normal way to handle this kind of thing is to add a new function (rpmGlob2() or similar, ugly as it may be) with the flags argument, and make the original call that with flags that equal to prior behavior. That in a commit of it's own (this is good for proving the original interface still works as before) and only then update callers to use the new API where needed - only the rpmGlob() calls in build/files.c need changing then.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2159#pullrequestreview-1081493361
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2159/review/1081493361 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220822/3308bc38/attachment-0001.html>