[Rpm-maint] [rpm-software-management/rpm] Unify glob fallback behavior (PR #2159)

[Panu Matilainen]

@pmatilai commented on this pull request.



>   * @param[out] *argcPtr	no. of paths
  * @param[out] *argvPtr	ARGV_t array of paths
  * @return		0 on success
  */
-int rpmGlob(const char * pattern, int * argcPtr, ARGV_t * argvPtr);
+int rpmGlob(const char * pattern, rpmglobFlags flags,
+	    int * argcPtr, ARGV_t * argvPtr);

Yup, there's the soname bump of course, which would allow us to do this, but it should be mentioned in the commit message. In general, preserving API where possible is good, but rpmGlob() is one of those cases where you wonder if anything at all outside rpm itself is using it, ie is it worth the trouble at all.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2159#discussion_r952232547
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2159/review/1081583686 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220823/41217f71/attachment.html>