[Rpm-maint] [rpm-software-management/rpm] Unify glob fallback behavior (PR #2159)
Michal Domonkos
notifications at github.com
Tue Aug 23 07:24:38 UTC 2022
> Hmm. In general explicit is preferable to implicit, but is there a concrete use-case to not just always silently fallback on the original name if glob fails? In our usage, that is.
Hmm, it's a valid point, I'll think about it when I'm updating this PR (with the above suggestions). We'll probably still need the flags parameter for the log message, but maybe even that could just be printed always.
Originally, I thought the fallback could have some unintended consequences in the `rpmGlob()` usages which this PR is not touching, but thinking about it, you're probably right. There's not many usages left, actually, so might as well just make it the default.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2159#issuecomment-1223660247
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2159/c1223660247 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220823/e5011c8a/attachment.html>
More information about the Rpm-maint
mailing list