[Rpm-maint] [rpm-software-management/rpm] Unify glob fallback behavior (PR #2159)

[Michal Domonkos]

@dmnks commented on this pull request.



> @@ -281,7 +281,7 @@ static int loadKeyringFromFiles(rpmts ts)
     int nkeys = 0;
 
     rpmlog(RPMLOG_DEBUG, "loading keyring from pubkeys in %s\n", pkpath);
-    if (rpmGlob(pkpath, NULL, &files)) {
+    if (rpmGlob(pkpath, RPMGLOB_NONE, NULL, &files)) {

This seems like a counter-example to the above, i.e. here we most likely do want to detect the case of no matches (which `RPMGLOB_NOCHECK` would prevent).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2159#pullrequestreview-1081857030
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2159/review/1081857030 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220823/8823f43b/attachment.html>