[Rpm-maint] [rpm-software-management/rpm] Use unsigned integers more consistently in the handling of tag data (PR #2316)

[Daniel Alley]

@dralley commented on this pull request.



> @@ -568,15 +568,15 @@ static int regionSwab(indexEntry entry, int il, int dl,
 	    }
 	}   break;
 	case RPM_INT32_TYPE:
-	{   int32_t * it = ie.data;
+	{   uint32_t * it = ie.data;

See the INT64 type handling above.  Additionally `htonll()`, `htonl()`, and `htons()` all work with unsigned integers so the casting as signed integers, while probably innocuous, is confusing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2316#pullrequestreview-1210209539
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2316/review/1210209539 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221208/cf2de798/attachment.html>