[Rpm-maint] [rpm-software-management/rpm] unable to import GPG keys if bit 7 "critical" of the subpacket type is set (Issue #2323)

[Ricardo]

Hi,

I try to debug an issue we ran into while trying to import GPG keys generate using GO https://github.com/ProtonMail/go-crypto

The sub package type "Issuer ID" is always set "critical": https://github.com/ProtonMail/go-crypto/blob/cf6655e29de41fd667b667c8bc291f7dac05a393/openpgp/packet/signature.go#L845

According to RFC https://www.rfc-editor.org/rfc/rfc4880#section-5.2.3.1 the evaluation should fail if the critical bit is set **AND** the evaluation for this sub packet type is **NOT** implemented.

And this line should take care of this: https://github.com/rpm-software-management/rpm/blob/8e6108a5964c7289f3db70f3d188293276416528/rpmio/rpmpgp_internal.c#L369-L370

Unfortunately with the latest version of SuSE Linux this validation somehow triggers wrong results.

I'm not sure where the culprit lies here.
Sample keys to test it can be found here: https://github.com/ProtonMail/go-crypto/issues/134
The rpm version used here is `RPM version 4.14.3`

 Thank you

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2323
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/issues/2323 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221212/caecce96/attachment-0001.html>