[Rpm-maint] [rpm-software-management/rpm] Add x86-64 architecture levels (v2-v4) as architectures (PR #2315)

Neal Gompa (ニール・ゴンパ) notifications at github.com
Thu Dec 22 10:17:02 UTC 2022


@Conan-Kudo commented on this pull request.



> @@ -1063,6 +1063,10 @@ package or when debugging this package.\
 #
 %ix86   i386 i486 i586 i686 pentium3 pentium4 athlon geode
 
+#------------------------------------------------------------------------------
+# arch macro for all supported x86_64 processors
+%x86_64	x86_64 x86_64_v2 x86_64_v3 x86_64_v4 amd64 em64t

I've slept on this and thought about it, and I think I like @dirkmueller's original suggestion of just dropping the `-` instead of converting it to an underscore. It's slightly more readable and less confusing. Can you do that, please?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2315#discussion_r1055305010
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2315/review/1227438375 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221222/1051283c/attachment.html>


More information about the Rpm-maint mailing list