[Rpm-maint] [rpm-software-management/rpm] Fix IMA signature fubar, take III (#1833, RhBug:2018937) (PR #1914)

Panu Matilainen notifications at github.com
Wed Feb 9 07:23:25 UTC 2022


@pmatilai commented on this pull request.



> +	offs[i] = t - bin;
+	*offsetp = offs;
+
+	rpmtdFreeData(&td);
+    }
+    return bin;
+}
+
+/* Convert a tag of hex strings to binary presentation */
+static uint8_t *hex2bin(Header h, rpmTagVal tag, rpm_count_t num, size_t len)
+{
+    struct rpmtd_s td;
+    uint8_t *bin = NULL;
+
+    if (headerGet(h, tag, &td, HEADERGET_MINMEM) && rpmtdCount(&td) == num) {
+	uint8_t *t = bin = xmalloc(num * len);

Suggesting uncompilable changes is not particularly helpful.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1914#discussion_r802330042
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1914/review/877006962 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220208/3952ccd0/attachment.html>


More information about the Rpm-maint mailing list