[Rpm-maint] [rpm-software-management/rpm] Disarm 21 year old landmine in the rpmfi API (PR #1916)

[Panu Matilainen]

The directory index must only be changed in sync with file iteration,
otherwise you get garbage out. The NOTYET'ed rpmfiDI() seems to suggest an
idea to have a separate mode of directory-only iteration in which context
rpmfiSetDX() would've perhaps made sense, but as it is this is plain
dangerous. Thankfully these APIs so broken that there can be no
legitimate users, so we can just turn them into a no-op until we have
to bump the soname next time.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1916

-- Commit Summary --

  * Disarm 21 year old landmine in the rpmfi API

-- File Changes --

    M lib/rpmfi.c (34)
    M lib/rpmfi.h (21)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1916.patch
https://github.com/rpm-software-management/rpm/pull/1916.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1916
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1916 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220209/6a8e50fd/attachment.html>