[Rpm-maint] [rpm-software-management/rpm] Make %{buildsubdir} usable without being a side effect of %setup (PR #1925)

[Panu Matilainen]

This has been on my todo for ages but kept postponing as the sheer number of subtle details needing careful review here is depressing, despite basically wanting to get this in. 

Inside doSetupMacro(), except for one related to defining it, all the %buildsubdir-related conditionals are redundant (and thus better removed) because it was just defined in that function (or guaranteed defined elsewhere). With those removed I think this'll look quite a bit clearer.

Other random related thoughts:
- `%setup` behavior becomes more erratic here: `%setup -n` will override an existing buildsubdir, otherwise it depends on whether it was previously defined or not. I think this at least calls for some new output for diagnostics, but also makes me wonder... %buildsubdir should not be allowed to change once defined.
- I think a package with a %build section ought to have %buildsubdir defined as mandatory for overall sanity, but not necessarily in the scope of this patch.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1925#issuecomment-1042684949
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1925/c1042684949 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220217/e733de3b/attachment.html>