[Rpm-maint] [rpm-software-management/rpm] Make %{buildsubdir} usable without being a side effect of %setup (PR #1925)

[Florian Festi]

Yeah, the question is whether this should keep the old behaviour or if we want to switch to something more sane within the patch. Technically it would be nicer if a behaviour change would go into a separate patch. Otoh keeping the same behaviour and allowing to overwrite %buildsubdir in the spec might be difficult to do.

Current behaviour is overwriting %buildsubdir with every %setup call. The issue with this patch is that %setup -n changes %buildsubdir but later %setup call won't set it back. I wonder if %setup -n should save %buildsubdir and follwing %setup without -n should restore it. While this is kinda strange on its own it is very close to the old behaviour while still allowing to overwrite %buildsubdir from the outside.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1925#issuecomment-1042768321
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1925/c1042768321 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220217/dda77657/attachment.html>