[Rpm-maint] [rpm-software-management/rpm] Make %{buildsubdir} usable without being a side effect of %setup (PR #1925)

[Panu Matilainen]

The more I think about it, the less I like the idea of having %buildsubdir change across the spec, because that will relate to spec parse time and not actual build, and ultimately there can only be one because of %doc, %license and %clean and I'd rather not have some random spec decide which part of my filesystem gets wiped out when it happens to execute %clean (of course specs can do that anyhow, but an 'rm -rf' is easier to spot than an innocent looking %define).

The use-case behind this patch was "subclass debuginfo generation on weird platforms and packages that build for more than one target inside the same build" and I'm not sure what to think of it. 

I'm easier sold to the case of multiple %setup (just because the unpack options for multiple sources get increasingly wacko) and having it behave sanely (subdir set from the first, not last) than that...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1925#issuecomment-1042810121
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1925/c1042810121 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220217/17838528/attachment.html>