[Rpm-maint] [rpm-software-management/rpm] Reimplement --restore as a transaction element, obsolete --setperms & co (PR #1894)

Panu Matilainen notifications at github.com
Tue Jan 25 08:08:15 UTC 2022


@pmatilai commented on this pull request.



> @@ -98,6 +98,21 @@ static rpmRC headerCheckPayloadFormat(Header h) {
     return rc;
 }
 
+static void addElement(tsMembers tsmem, rpmte te, int oc)

I don't care much for the name either but as it's just an internal helper, it's not worth getting stuck in a bikeshed. A tiny static internal helper doesn't deserve a long name, but I can change to addMember() if that helps.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1894#discussion_r791449656
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1894/review/861913313 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220125/5d6e34ca/attachment-0001.html>


More information about the Rpm-maint mailing list