[Rpm-maint] [rpm-software-management/rpm] Make rpm2cpio.sh more robust (PR #2115)

Florian Festi notifications at github.com
Fri Jul 1 13:14:57 UTC 2022


Processing binary data in shell is very fragile. In this case the code breaks when encountering newline characters (\n) as part of the header size which is a binary integer.

Reported as https://bugzilla.redhat.com/show_bug.cgi?id=1983015
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2115

-- Commit Summary --

  * rpm2cpio.sh: Check for header magic
  * rpm2cpio.sh: Don't drop newlines from header sizes
  * rpm2cpio.sh: strip null bytes with tr

-- File Changes --

    M scripts/rpm2cpio.sh (16)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2115.patch
https://github.com/rpm-software-management/rpm/pull/2115.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2115
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2115 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220701/47c89a37/attachment.html>


More information about the Rpm-maint mailing list