[Rpm-maint] [rpm-software-management/rpm] Don't error git based %autosetup when master branch does not exist (PR #2120)

[Michal Domonkos]

Ugh, nice find!

TBH, I'm not entirely sure about the intended use case of the original patch, either. We initialize a new repo with `%autosetup -S git`, without any history, so updating the master/main branch with its upstream counterpart isn't as easy as adding a remote and doing a `git pull`, anyway. And if that's what you (the general you) want to do, there's already manual work involved, at which point manually checking out a new topic branch and resetting master/main to the first commit is not a big deal.

I can imagine interesting ways to automate this whole workflow, e.g. by us cloning the corresponding repo (instead of initializing a new one), pinpointing the exact commit corresponding to the tarball (e.g. by a git tag if that's available) and then applying the patches on a separate branch, but that's a bit more involved and opinionated than what we do right now. It also might be redundant in light of https://packit.dev/source-git/.

For now, I'll just revert this patch in dist-git to fix the immediate regression in Fedora and will leave this open so that we can think of a more proper way to do this branching, if at all (or just revert the patch upstream and close this).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2120#issuecomment-1180209173
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2120/c1180209173 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220711/191e3fef/attachment.html>