[Rpm-maint] [rpm-software-management/rpm] Add support for --oldpackage to --freshen (PR #2122)

[Michal Domonkos]

@dmnks commented on this pull request.



>      if (name != NULL)
         mi = rpmtsInitIterator(ts, RPMDBI_NAME, name, 0);
     if (rpmtsColor(ts) && arch)
 	rpmdbSetIteratorRE(mi, RPMTAG_ARCH, RPMMIRE_DEFAULT, arch);
 
     while ((oldH = rpmdbNextIterator(mi)) != NULL) {
+	if (allowOld)

OK, this is how it works in this current form:

```sh
$ rpm -Uhv ~/rpmbuild/RPMS/noarch/versiontest-2-1.noarch.rpm
Verifying...                          ################################# [100%]
Preparing...                          ################################# [100%]
        package versiontest-2-1.noarch is already installed
$ rpm -Fhv ~/rpmbuild/RPMS/noarch/versiontest-2-1.noarch.rpm
$ rpm -Fhv --oldpackage ~/rpmbuild/RPMS/noarch/versiontest-2-1.noarch.rpm
Verifying...                          ################################# [100%]
Preparing...                          ################################# [100%]
        package versiontest-2-1.noarch is already installed
```

So yeah, the check is there, however it doesn't get as far in the normal case without `--oldpackage` where it prints nothing. I'd suggest doing the same here, too.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2122#discussion_r921163210
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2122/review/1038881081 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220714/57995fda/attachment.html>