[Rpm-maint] [rpm-software-management/rpm] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite … (PR #1936)

[Michal Domonkos]

@dmnks requested changes on this pull request.

This patch currently fails in CI. Also, see comments inline. Would you be up to revisiting it?

> @@ -50,6 +50,20 @@ else
     CAP_DISABLED=true;
 fi
 
+# Enable malloc-check as a cheap way to find some use-after-free and
+# uninitialized read problems when using glibc, and doesn't affect
+# normal operation or other libc.
+# Only for GLIBC >=2.34

This seems like an omission from the previous version of this patch that was supposed to check for the GLIBC version.

> @@ -50,6 +50,20 @@ else
     CAP_DISABLED=true;
 fi
 
+# Enable malloc-check as a cheap way to find some use-after-free and
+# uninitialized read problems when using glibc, and doesn't affect
+# normal operation or other libc.
+# Only for GLIBC >=2.34
+
+random="$(awk 'BEGIN{srand(); printf "%d\n",(rand()*255)}')"
+if _GLIBC_VERSION=$(getconf GNU_LIBC_VERSION 2>/dev/null)

This is not a valid shell conditional. Can you clarify what it's supposed to check?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1936#pullrequestreview-1041854101
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1936/review/1041854101 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220718/a07e204e/attachment.html>