[Rpm-maint] [rpm-software-management/rpm] Add shell-like escape support to %files (PR #2103)

Panu Matilainen notifications at github.com
Thu Jun 23 10:46:36 UTC 2022


@pmatilai commented on this pull request.



> @@ -107,14 +107,6 @@ char * rpmGenPath	(const char * urlroot,
  */
 char * rpmGetPath (const char * path, ...) RPM_GNUC_NULL_TERMINATED;
 
-/** \ingroup rpmfileutil
- * Check whether pattern contains any glob metacharacters.
- * @param pattern	glob pattern
- * @param quote		allow backslash quoting of metacharacters?
- * @return		1 if pattern contains globs, 0 otherwise
- */
-int rpmIsGlob(const char * pattern, int quote);

rpmIsGlob() is part of the public API so care needs to be taken when removing. As it happens, we'll be bumping the soname in 4.19 so just now removing it is okay (I doubt it's being used outside rpm anyway), but its removal does need to be documented in the commit message.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2103#pullrequestreview-1016791951
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2103/review/1016791951 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220623/ff2bae47/attachment.html>


More information about the Rpm-maint mailing list