[Rpm-maint] [rpm-software-management/rpm] Add shell-like escape support to %files (PR #2103)

Panu Matilainen notifications at github.com
Thu Jun 23 11:05:12 UTC 2022


@pmatilai commented on this pull request.



>  
-    s = argvJoin(sb, " ");
+	poptParseArgvString(s, &pac, &pav);
+	for (j = 0; j < pac; j++)
+	    argvAdd(&sb, pav[j]);

I wonder if this strange little dance is worth it to preserve multiple arguments on a single manifest line. It is documented behavior so from that POV this is the right thing to do, just wondering if the behavior itself is sane :sweat_smile: I certainly don't remember ever seeing a manifest with more than a single argument per line - and most people have never so much as heard of rpm manifest files...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2103#pullrequestreview-1016813201
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2103/review/1016813201 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220623/6f7351cd/attachment.html>


More information about the Rpm-maint mailing list