[Rpm-maint] [rpm-software-management/rpm] Add shell-like escape support to %files (PR #2103)

Michal Domonkos notifications at github.com
Thu Jun 23 14:19:03 UTC 2022


@dmnks commented on this pull request.



> @@ -107,14 +107,6 @@ char * rpmGenPath	(const char * urlroot,
  */
 char * rpmGetPath (const char * path, ...) RPM_GNUC_NULL_TERMINATED;
 
-/** \ingroup rpmfileutil
- * Check whether pattern contains any glob metacharacters.
- * @param pattern	glob pattern
- * @param quote		allow backslash quoting of metacharacters?
- * @return		1 if pattern contains globs, 0 otherwise
- */
-int rpmIsGlob(const char * pattern, int quote);

Sorry, I somehow missed the fact that this was about the `rpmIsGlob()` and not `rpmGlob()` declaration, I updated the latter only :facepalm: 

And thanks for noticing, based on where we are in the 4.18 cycle, I guess we're not going to include these commits in it anyway, so in that case, the planned 4.19 bump is a good opportunity for this, as well as for the subtle `rpmGlob()` change, indeed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2103#discussion_r905082274
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2103/review/1017097487 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220623/b4990e33/attachment-0001.html>


More information about the Rpm-maint mailing list