[Rpm-maint] [rpm-software-management/rpm] Fix expected test output when using Sequoia. (PR #2063)

[Neal H. Walfield]

@nwalfield commented on this pull request.



> @@ -621,7 +621,14 @@ rpmRC rpmtsImportPubkey(const rpmts ts, const unsigned char * pkt, size_t pktlen
         if (krc != RPMRC_OK) {
             rpmlog(RPMLOG_ERR, "%s\n", lints);
         } else {
-            rpmlog(RPMLOG_WARNING, "%s\n", lints);
+            // Don't show the warning if --quiet was provided.  With
+            // --quiet, RPMLOG_WARNING messages are still shown, but
+            // RPMLOG_NOTICE are not.  We can't use RPMLOG_NOTICE
+            // here, as the output needs to go to stdderr.  So, we
+            // check the warning level explicitly.
+            if (rpmIsNormal()) {
+                rpmlog(RPMLOG_WARNING, "%s\n", lints);

I'm also not so happy with my proposed solution.  `--nolint` seems like a small improvement, but is still not ideal.  I think this is only needed for the test suite, so it is probably best to just deal with it in the test suite and not expose new API.  Or do you envision other places where it is necessary or useful to suppress the lints?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2063#discussion_r907010130
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2063/review/1019655942 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220626/bd18bf8c/attachment.html>