[Rpm-maint] [rpm-software-management/rpm] Fix expected test output when using Sequoia. (PR #2063)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -621,7 +621,14 @@ rpmRC rpmtsImportPubkey(const rpmts ts, const unsigned char * pkt, size_t pktlen
         if (krc != RPMRC_OK) {
             rpmlog(RPMLOG_ERR, "%s\n", lints);
         } else {
-            rpmlog(RPMLOG_WARNING, "%s\n", lints);
+            // Don't show the warning if --quiet was provided.  With
+            // --quiet, RPMLOG_WARNING messages are still shown, but
+            // RPMLOG_NOTICE are not.  We can't use RPMLOG_NOTICE
+            // here, as the output needs to go to stdderr.  So, we
+            // check the warning level explicitly.
+            if (rpmIsNormal()) {
+                rpmlog(RPMLOG_WARNING, "%s\n", lints);

Let me put it this way: I can't recall ever regretting adding a disabler for something (in rpm) even if there's no immediately obvious need, but not adding one, several times :sweat_smile: 
As the lint can actually cause the operation to fail, it'd actually be good to have a disabler for it, regardless of the test-suite issue. Biggest problem is finding out a good place for it, neither vsflags or main transaction flags seem quite appropriate.

In the meanwhile, just dealing with the output difference seems like a reasonable way forward.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2063#discussion_r907037469
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2063/review/1019694411 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220626/caf978b9/attachment.html>