[Rpm-maint] [rpm-software-management/rpm] Handle missing RPMTAG_ARCH in RPMTAG_ARCHSUFFIX (PR #1941)

Panu Matilainen notifications at github.com
Tue Mar 1 11:00:43 UTC 2022


RPMTAG_ARCHSUFFIX from commit e6a6399cb4c87f049bb75b8da83f5759522bcc58
assumes all headers have RPMTAG_ARCH, but a notable exception is gpg-pubkey
headers in rpmdb, causing segfaults on `rpm -qa` on normal systems.

Special case conditionals in queryformats get ugly and error-prone real
fast, which is why we have all the NEVRA formatter extensions. Avoid
adding yet more of those tags by handling the dot formatting in
ARCHSUFFIX instead - the "suffix" in the name seems to imply this
anyway.

Also add tests to cover the common -qa cases.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1941

-- Commit Summary --

  * Handle missing RPMTAG_ARCH in RPMTAG_ARCHSUFFIX

-- File Changes --

    M docs/manual/tags.md (2)
    M lib/tagexts.c (13)
    M macros.in (2)
    M tests/rpmdb.at (32)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1941.patch
https://github.com/rpm-software-management/rpm/pull/1941.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1941
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1941 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220301/12bc3df7/attachment.html>


More information about the Rpm-maint mailing list