[Rpm-maint] [rpm-software-management/rpm] Fix file descriptor leak regression on install (#1947) (PR #1954)

[Demi Marie Obenour]

@DemiMarie commented on this pull request.



> @@ -208,7 +209,7 @@ static int fsmMkfile(int dirfd, rpmfi fi, struct filedata_s *fp, rpmfiles files,
 	if (fp->sb.st_nlink > 1) {
 	    *firstlink = fp;
 	    *firstlinkfile = fd;
-	    *firstdir = dirfd;
+	    *firstdir = dup(dirfd);

Should this be `fcntl(dirfd, F_DUPFD_CLOEXEC)` instead?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1954#pullrequestreview-909210885
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1954/review/909210885 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220314/9dae00fa/attachment.html>