[Rpm-maint] [rpm-software-management/rpm] Make pgpDigParams opaque (PR #1980)

[nwalfield]

@nwalfield commented on this pull request.



> @@ -33,7 +33,13 @@ typedef struct pgpDig_s * pgpDig;
  */
 typedef struct pgpDigParams_s * pgpDigParams;
 
-typedef uint8_t pgpKeyID_t[8];
+
+/** \ingroup rpmpgp
+ * The length (in bytes) of a binary (not hex encoded) key ID.
+ */
+#define PGP_KEYID_LEN 8

It's not possible to replace the use of Iey IDs with fingerprint without reworking the callers.  First, the fingerprint is not always available.  For instance, many signatures only include an issuer subpacket with a Key ID and not an issuer fingerprint subpacket with a fingerprint.  Second, v3 and the upcoming v5 fingerprints are different sizes from v4 fingerprints.  As such, a fixed sized buffer, which rpm currently uses, is not reasonable.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1980#discussion_r838323777
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1980/review/925810913 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220330/d13c997e/attachment-0001.html>