[Rpm-maint] [rpm-software-management/rpm] Make pgpDigParams opaque (PR #1980)

[nwalfield]

@nwalfield commented on this pull request.



> +/** \ingroup rpmpgp
+ * Retrieve the object's creation time.
+ *
+ * If the object is a signature, then this returns the signature's creation
+ * time.
+ *
+ * If the object is a certificate, then this returns the primary key's key
+ * creation time.
+ *
+ * If the object is a subkey, then this returns the subkey's key creation
+ * time.
+ *
+ * param digp		parameter container
+ * return		seconds since the UNIX Epoch.
+ */
+uint32_t pgpDigParamsTime(pgpDigParams digp);

The tricky part is that this function is already overloaded.  In the case of signatures, the time stamp refers to the [signature creation time](https://datatracker.ietf.org/doc/html/rfc4880#section-5.2.3.4).  In the case of keys, the time stamp refers to the key's [key creation time](https://datatracker.ietf.org/doc/html/rfc4880#section-5.5.2).  Of course any valid key also has a valid binding signature, which also has a signature creation time :/.  But, since they are both creation times, your suggestion is an improvement.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1980#discussion_r838329202
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1980/review/925818588 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220330/c84eb74e/attachment.html>