[Rpm-maint] [rpm-software-management/rpm] Make pgpDigParams opaque (PR #1980)

[nwalfield]

@nwalfield commented on this pull request.



> + *
+ * If the object is a subkey, then this returns the version of the subkey's
+ * key packet.
+ *
+ * param digp		parameter container
+ * return		the object's version
+ */
+int pgpDigParamsVersion(pgpDigParams digp);
+
+/** \ingroup rpmpgp
+ * Retrieve the object's creation time.
+ *
+ * If the object is a signature, then this returns the signature's creation
+ * time.
+ *
+ * If the object is a certificate, then this returns the primary key's key

That's what [the comment on the `time` field suggests](https://github.com/rpm-software-management/rpm/blob/7e7266c/rpmio/digest.h#L31), and the code [seems](https://github.com/rpm-software-management/rpm/blob/7e7266c9af883ce49b3516a5bd099d218e8e3fac/rpmio/rpmpgp.c#L483) to [agree](https://github.com/rpm-software-management/rpm/blob/7e7266c9af883ce49b3516a5bd099d218e8e3fac/rpmio/rpmpgp.c#L787).  What do you think the code does now?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1980#discussion_r838343333
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1980/review/925838284 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220330/5ba7c85c/attachment-0001.html>