[Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

Panu Matilainen notifications at github.com
Thu Nov 3 07:48:54 UTC 2022


@pmatilai commented on this pull request.



> @@ -273,6 +273,15 @@ static int doSetupMacro(rpmSpec spec, const char *line)
 	free(buf);
     }
 
+    /* mkdir for dynamic specparts */
+    buf = rpmExpand("%{__mkdir} SPECPARTS", NULL);
+    appendBuf(spec, buf, 1);
+    free(buf);
+
+    buf = rpmGenPath("%{u2p:%{_builddir}}", "%{buildsubdir}", "SPECPARTS");
+    rpmPushMacro(spec->macros, "specpartsdir", NULL, buf, RMIL_SPEC);

Indeed, I was thinking about a macro for SPECPARTS specifically, and drop any references to the explicit value from both the code *and documentation*. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1485#discussion_r1012579408
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1485/review/1166416730 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221103/0c704cec/attachment.html>


More information about the Rpm-maint mailing list