[Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

[Panu Matilainen]

@pmatilai commented on this pull request.



> +	    if (checkForEncoding(pkg->header, 0) != RPMRC_OK) {
+		badenc = 1;
+	    }
+	}
+	if (badenc)
+	    goto errxit;
+    }
+
+    closeSpec(spec);
+
+exit:
+    return spec;
+
+errxit:
+    if (!secondary)
+	rpmSpecFree(spec);

I think just moving the initial spec allocation (+ other setup) to parseSpecSection() should make it a whole lot less lopsided wrt the allocation, and thus less ugly. We can't help the recursing from buildarch, but we're not going to make things *worse*.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1485#discussion_r1015123195
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1485/review/1169964700 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221107/03803e59/attachment.html>