[Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

[Panu Matilainen]

@pmatilai commented on this pull request.



> +	    if (checkForEncoding(pkg->header, 0) != RPMRC_OK) {
+		badenc = 1;
+	    }
+	}
+	if (badenc)
+	    goto errxit;
+    }
+
+    closeSpec(spec);
+
+exit:
+    return spec;
+
+errxit:
+    if (!secondary)
+	rpmSpecFree(spec);

Another possibility may be a kind of opposite direction: handle it inline specParse(), just move stuff that doesn't belong there out of the way. I have no idea why I planted the openmp thread fubar right in the middle of specParse(), it sure does not have to be just there, it may just as well be done from rpmSpecParse() instead, probably ditto for various other pieces.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1485#discussion_r1015128682
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1485/review/1169972714 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221107/3ec61628/attachment-0001.html>