[Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

[Florian Festi]

@ffesti commented on this pull request.



> +	    if (checkForEncoding(pkg->header, 0) != RPMRC_OK) {
+		badenc = 1;
+	    }
+	}
+	if (badenc)
+	    goto errxit;
+    }
+
+    closeSpec(spec);
+
+exit:
+    return spec;
+
+errxit:
+    if (!secondary)
+	rpmSpecFree(spec);

The issue here is that we want to alter the spec object with parseSpecSection() for the dynamic spec feature. So we need to pass the spec object no matter what. Doing the object creating in parseSpecSection() only bloats that function and increases the different behaviors for the two use cases.

Not quite sure what you mean with "handling it inline specParse()". We still need something we can pass the spec object to. While I am fine with moving stuff out of specParse() I think this is a bit out of scope here.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1485#discussion_r1015488140
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1485/review/1170497734 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221107/515f3a2e/attachment-0001.html>