[Rpm-maint] [rpm-software-management/rpm] Fix regression: -bp should check BuildRequires (PR #2271)

[Florian Festi]

There are two different things to consider: When are BuildRequires checks done during the build process and whether to do it depending on what stage/subcommand are executed. Looking at https://github.com/rpm-software-management/rpm/blob/master/build/build.c#L379 and https://github.com/rpm-software-management/rpm/blob/master/build/build.c#L388 the BuildRequiresCheck seems to be executed at the right time.

This case statement in rpmbuild.c with all its fallthroughs is a bit difficult to read, but the patch is IMHO correct in putting the BuildDependency check at the bottom of the fall through  block - enabling it also for `-bp`.

There is an argument to be made that the BuildDependency check should also be made when --short-circuit is given (which it is currently not (except for prep after this patch or `-bf` before) but may be this is a separate issue.

So I don't see any other sub commands that should have trouble with the BuildDependency check not being executed properly (assuming the short-circuit issue is ignored). So the patch should actually be sufficient IMHO. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2271#issuecomment-1315357683
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2271/c1315357683 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221115/2f146fca/attachment-0001.html>