[Rpm-maint] [rpm-software-management/rpm] Fix regression: -bp should check BuildRequires (PR #2271)

[Michal Domonkos]

> There is an argument to be made that the BuildDependency check should also be made when --short-circuit is given (which it is currently not (except for prep after this patch or `-bf` before) but may be this is a separate issue.

Yeah, sounds like a separate issue to me, if at all. We might as well declare that the prep stage is the first one that cares about BuildRequires so if you skip it, then they won't be checked. Maybe it would deserve a mention in the man page?

> So I don't see any other sub commands that should have trouble with the BuildDependency check not being executed properly (assuming the short-circuit issue is ignored). So the patch should actually be sufficient IMHO.

I don't see any other use cases either, so should be fine as it is.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2271#issuecomment-1316773035
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2271/c1316773035 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221116/b015b0c2/attachment.html>