[Rpm-maint] [rpm-software-management/rpm] rpmsign: Adopting PKCS#11 opaque keys support in libfsverity for fsverity signatures (#1779)

Mon Nov 21 13:54:38 UTC 2022

Okay this has fallen through the cracks for so long it's damn embarrassing to begin a review at this point. Sorry about that.

Prefix the newly introduced cli-switches and macro names with verity_ or something, to make it clear these are only related to that whereas PKCS#11 could be relevant for other signing stuff too.

The other issue here is the lack of tests, goes for all of fsverity and ima too, a trend we can't let continue further. I get that this is primarily about hardware options but one would it's testable in software.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1779#issuecomment-1322102252
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1779/c1322102252 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221121/018bf88c/attachment-0001.html>