[Rpm-maint] [rpm-software-management/rpm] Use cmake imported targets to let it sort out the compiler flag details (PR #2301)

[Panu Matilainen]

These imported targets passed to target_link_library() are supposed to handle all the pesky compilation, linkage etc details behind the scenes. I was pretty sure I was missing a trick with this, but this sure isn't exactly underlined in the documentation.

Unroll the supposedly helpful loop for handling plugins: turns out doing this cmake native way is plenty shorter and more obvious too. The unroll kinda belongs to a separate commit but that'd be rather painful for very little if any gain.

Fixes: #2269 and a whole class of similar cases, allegedly
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2301

-- Commit Summary --

  * Use cmake imported targets to let it sort out the compiler flag details

-- File Changes --

    M CMakeLists.txt (34)
    M build/CMakeLists.txt (16)
    M lib/CMakeLists.txt (10)
    M plugins/CMakeLists.txt (45)
    M rpmio/CMakeLists.txt (36)
    M sign/CMakeLists.txt (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2301.patch
https://github.com/rpm-software-management/rpm/pull/2301.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2301
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2301 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221128/0174a949/attachment-0001.html>