[Rpm-maint] [rpm-software-management/rpm] Add proper quotation support to %files (PR #2206)

Panu Matilainen notifications at github.com
Tue Oct 4 06:52:50 UTC 2022


@pmatilai commented on this pull request.



>  	t = NULL;
+	end = s + strlen(s) - 1;
+
+	/* Syntax checks */
+	if (quotes == 1) {
+	    rpmlog(RPMLOG_ERR, _("Missing quote: %s\n"), s);

I was about to say this should report a line number, but the existing error message doesn't have that either and the needed context is missing multiple layers of calls above, so lets not go there now. This series is long enough as it is :laughing: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2206#pullrequestreview-1129379847
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2206/review/1129379847 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221003/f0925e2b/attachment.html>


More information about the Rpm-maint mailing list