[Rpm-maint] [rpm-software-management/rpm] Fix some type confusion bugs in the internal OpenPGP implementation (PR #2242)

Panu Matilainen notifications at github.com
Wed Oct 26 06:42:08 UTC 2022


@pmatilai commented on this pull request.



> @@ -1124,6 +1124,9 @@ rpmRC pgpVerifySignature(pgpDigParams key, pgpDigParams sig, DIGEST_CTX hashctx)
     if (sig == NULL || ctx == NULL)
 	goto exit;
 
+    if (sig->tag != PGPTAG_SIGNATURE)
+	goto exit; /* not a signature */

This is another very redundant comment, also misplaced. Just drop.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2242#pullrequestreview-1155938713
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2242/review/1155938713 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20221025/0e661e30/attachment.html>


More information about the Rpm-maint mailing list