[Rpm-maint] [rpm-software-management/rpm] Add support for generating buildinfo file as subpackage (#1532)
Demi Marie Obenour
notifications at github.com
Thu Sep 1 06:32:19 UTC 2022
@DemiMarie commented on this pull request.
> +# in this Software without prior written authorization of the copyright holder.
+#
+
+set -e -o pipefail
+
+getos() {
+ # shellcheck disable=SC1091
+ test -r /etc/os-release && . /etc/os-release
+ if test -z "${ID}"; then
+ ID="$(cat /etc/system-release)"
+ fi
+ printf '%s' "${ID}"
+}
+
+RPM_BUILD_ROOT="$1"
+RPM_BUILD_DIR="$2"
> Rpm checks against embedded BUILDROOT in the packages already and fails the build when found, we should probably extend that to cover BUILD DIR because references to that are equally a bug, always.
Where is this check? It wasn’t obvious from a quick search.
> (it should be in the commit messages of this thing!)
@fepitre time to add them!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1532#discussion_r960266374
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/1532/review/1092835805 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220831/8e1a79fa/attachment.html>
More information about the Rpm-maint
mailing list