[Rpm-maint] [rpm-software-management/rpm] Add support for generating buildinfo file as subpackage (#1532)

[Panu Matilainen]

@pmatilai commented on this pull request.



> +# in this Software without prior written authorization of the copyright holder.
+#
+
+set -e -o pipefail
+
+getos() {
+    # shellcheck disable=SC1091
+    test -r /etc/os-release && . /etc/os-release
+    if test -z "${ID}"; then
+        ID="$(cat /etc/system-release)"
+    fi
+    printf '%s' "${ID}"
+}
+
+RPM_BUILD_ROOT="$1"
+RPM_BUILD_DIR="$2"

Uh, right. So how about we discuss the design *here* instead.

I'm not totally up to speed with the intended purposes of this file, but assuming collecting this info is useful for one or more purposes (in principle I can agree with that)... One of the purposes seems to be allowing comparison between builds, but for that, placing the info inside sub-packages which you have to install (or at least unpack first) to even look at seems painful to say the least.

Sticking it into an rpm just because it's generated by rpm... I'm not sure it makes sense here. And even if it did, I don't know why anybody would want to *install* such a thing on their system (feel free to enlighten me). Since we're talking about a simple plain-text file here, it could just as well be stuffed into the header of an src.rpm-like package so you can compare packages by just querying them.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1532#discussion_r960584703
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1532/review/1093292237 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220901/a9b81414/attachment.html>