[Rpm-maint] [rpm-software-management/rpm] Make pgpPubkeyFingerprint() do something meaningful again (PR #2172)

[Panu Matilainen]

Commit 4bbeec134aab33e24f960be28a7b2198359c1f67 "fixed" an old
terminology confusion about keyid vs fingerprint, but in the process
broke pgpPubkeyFingerprint() for any external callers, as it now only
feeds on decoded packets whereas before it did the decoding by itself.
Add the decoding step back to the public function to make it usable outside
rpmpgp_internal.c again, retrieving a fingerprint seems like an useful
(public) API to have.

This is kind of a regression fix in that prior to commit
4bbeec134aab33e24f960be28a7b2198359c1f67 pgpPubkeyFingerprint() returned
meaningful data to the outside caller and afterwards it didn't, however
that commit broke the API anyhow so it's kinda complicated.
Maybe we should just call it a bugfix and be done with it.

Related to #1549
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2172

-- Commit Summary --

  * Make pgpPubkeyFingerprint() do something meaningful again

-- File Changes --

    M rpmio/rpmpgp_internal.c (15)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2172.patch
https://github.com/rpm-software-management/rpm/pull/2172.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2172
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2172 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220905/aade3ce8/attachment-0001.html>