[Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -37,7 +37,9 @@ enum rpmtransFlags_e {
     RPMTRANS_FLAG_NOCONTEXTS	= (1 <<  8),	/*!< from --nocontexts */
     RPMTRANS_FLAG_NOCAPS	= (1 <<  9),	/*!< from --nocaps */
     RPMTRANS_FLAG_NODB		= (1 << 10),	/*!< from --nodb */
-    /* bits 11-15 unused */
+    /* bits 11-13 unused */
+    RPMTRANS_FLAG_NOPREUNTRANS	= (1 << 14),	/*!< from --preuntrans */

Oh, actually this *was* mentioned in the commit message:

"Cheapskate on transaction flags are reuse pre/posttrans flags for these uninstall counterparts 
too, adding separate flags and disablers just doesn't seem worth it, especially as we're quite short of free bits." 

Always a good idea to explicitly explain things in the commit message, that way you have a double bookkeeping: if the two disagree, something isn't right :laughing: 
Thanks for spotting!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2177#discussion_r976063941
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2177/review/1114796621 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220920/c2ba19c7/attachment-0001.html>