[Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

[Panu Matilainen]

> pkgGoalString is missing entries for PKG_PREUNTRANS and PKG_POSTUNTRANS

Oh, indeed. Added now. It's quite amazing just how many places need to be touched for this crap :laughing: 

> Missing RPMSENSE_ flags means there is currently no way to declare Requires(preuntrans) and Requires(postuntrans). May be that is not necessary and we can use Requires(pretrans)/Requires(posttrans).
Reusing RPMSENSE_PRETRANS and RPMSENSE_POSTTRANS in that way raises the question whether they should be part of the _ERASE_ONLY_MASK, though. This is kinda weird.

That's a very good point! My thinking was that this does not need separate RPMSENSE tracking as these are not relevant for ordering, and for dependency checking it only matters that they are there before, or after, the transaction. Just like with pretrans/posttrans.

But actually, I think the real problem here is that RPMSENSE_PRETRANS and RPMSENSE_POSTTRANS are part of isInstallPreReq() when they shouldn't. They should be considered for isTransientReq() though.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2177#issuecomment-1254771382
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2177/c1254771382 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220922/fe66b4a8/attachment-0001.html>