[Rpm-maint] [rpm-software-management/rpm] Fix missing includes on macOS (PR #2571)
Panu Matilainen
notifications at github.com
Mon Aug 7 10:01:07 UTC 2023
Heh, I very nearly reverted the duplicate-filename patch as bogus, there's no casting away being done in the code. Luckily I did check this conversation first :laughing:
So the "weird" part here is why we were not seeing that const warning with glibc, but the answer is: because glibc has its own version of basename() where the argument *is* const. So yep, duping the path is the right thing to do, even if the posix basename() is dumb.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2571#issuecomment-1667563550
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2571/c1667563550 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230807/ebdac5f7/attachment.html>
More information about the Rpm-maint
mailing list