[Rpm-maint] [rpm-software-management/rpm] Enhance requires with version information from the build root. (PR #2372)

[Panu Matilainen]

@pmatilai commented on this pull request.



> +	    version = getLibtoolVer(linkmap->l_name);
+	}
+	if (version)
+	    (void) write(pipefd[1], version, strlen(version));
+	close(pipefd[1]);
+	free(version);
+	dlclose(dl_handle);
+	_exit(0);
+    } else {
+	ssize_t len;
+	close(pipefd[1]);
+	dest[0] = 0;
+	len = read(pipefd[0], dest, sizeof(dest));
+	if (len > 0) dest[len] = 0;
+	close(pipefd[0]);
+	wait(NULL);

Sorry I forgot to mention this yesterday, but we'll want to check the exit status of the child here. The segfault due to missing version was getting silently unnoticed because of that, I only noticed because execution was taking *far* too long for such a simple thing, and investigation turned up that segfault.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2372#pullrequestreview-1286541038
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2372/review/1286541038 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230206/dafe5dbb/attachment.html>