[Rpm-maint] [rpm-software-management/rpm] Enhance requires with version information from the build root. (PR #2372)

[Gordon Messmer]

@gordonmessmer commented on this pull request.



> +	    version = getLibtoolVer(linkmap->l_name);
+	}
+	if (version)
+	    (void) write(pipefd[1], version, strlen(version));
+	close(pipefd[1]);
+	free(version);
+	dlclose(dl_handle);
+	_exit(0);
+    } else {
+	ssize_t len;
+	close(pipefd[1]);
+	dest[0] = 0;
+	len = read(pipefd[0], dest, sizeof(dest));
+	if (len > 0) dest[len] = 0;
+	close(pipefd[0]);
+	wait(NULL);

I'm curious about this, because if the child process segfaults the parent's read() should return with no data read, and the process should continue without the version number.  It sounds like you're saying that it blocked on that read instead, and I'm not sure why that would happen.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2372#discussion_r1099708964
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2372/review/1288547156 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230207/0c6d6722/attachment-0001.html>