[Rpm-maint] [rpm-software-management/rpm] Enhance requires with version information from the build root. (PR #2372)

[Panu Matilainen]

@pmatilai commented on this pull request.



> +	    version = getLibtoolVer(linkmap->l_name);
+	}
+	if (version)
+	    (void) write(pipefd[1], version, strlen(version));
+	close(pipefd[1]);
+	free(version);
+	dlclose(dl_handle);
+	_exit(0);
+    } else {
+	ssize_t len;
+	close(pipefd[1]);
+	dest[0] = 0;
+	len = read(pipefd[0], dest, sizeof(dest));
+	if (len > 0) dest[len] = 0;
+	close(pipefd[0]);
+	wait(NULL);

Oh, it was falling through the read() alright, the delay comes from systemd-coredump kicking in on the child, and then continuing as if nothing had happened. Talking about 0.01s vs 0.5s execution time here, which is enough to be visually noticeable, very much so if you happen to feed more than one file at a time. 

The point though, the child crashing for any reason at all is something we want to notice and fail with an error in the parent.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2372#discussion_r1099731362
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2372/review/1288578916 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230207/d00288ec/attachment.html>