[Rpm-maint] [rpm-software-management/rpm] Header internals type cleanup (PR #2387)

Daniel Alley notifications at github.com
Mon Feb 13 04:11:09 UTC 2023


@dralley commented on this pull request.



>      uint8_t *dataStart;
     uint8_t *dataEnd;
 
     rpmTagVal regionTag;
-    int32_t ril;
-    int32_t rdl;
+    uint32_t ril;
+    uint32_t rdl;

Unrelated, but these short variable names are quite painful to read, not just here but pretty much everywhere

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2387#pullrequestreview-1294918918
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2387/review/1294918918 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230212/b437ba10/attachment.html>


More information about the Rpm-maint mailing list