[Rpm-maint] [rpm-software-management/rpm] Header internals type cleanup (PR #2387)

Panu Matilainen notifications at github.com
Mon Feb 13 08:51:07 UTC 2023


@pmatilai commented on this pull request.



>      uint8_t *dataStart;
     uint8_t *dataEnd;
 
     rpmTagVal regionTag;
-    int32_t ril;
-    int32_t rdl;
+    uint32_t ril;
+    uint32_t rdl;

I know. These are historical, and I don't even know what some of these internal acronyms (eg pe, pvlen) exactly stand for. The idea was to keep the existing names while refactoring in progress and then at least document, but looks we're still in the refactoring phase :D

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2387#discussion_r1104153942
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2387/review/1295174477 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230213/d38a6b5c/attachment.html>


More information about the Rpm-maint mailing list