[Rpm-maint] [rpm-software-management/rpm] rpmbuild is duplicating OS name in rpm package names when dist tag is in spec file (Discussion #2397)

[Panu Matilainen]

> Release: %{release}%{?dist}

This is a bad habit. If you want to pre-define the "base" part of the release (or any other similar part) in a macro, use a different name from the tag. Such as "%rel", or whatever. That's not the problem here and doing this wont (currently) break anything, but it's confusing (to yourself and the viewer) at best.

There are two ways you can get an extra dist there like that: either you have %_rpmfilename overridden to something peculiar including %{dist}, or something in the spec is directly or indirectly defining %distprefix or %dist itself. Impossible to say without the actual spec.

If you grab and build https://github.com/rpm-software-management/rpm/blob/master/tests/data/SPECS/mini.spec, do you get the dist in the package name as such? If not, what happens if you add %{?dist} to the Release: tag? 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2397#discussioncomment-5085280
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/repo-discussions/2397/comments/5085280 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20230222/099dd343/attachment-0001.html>